[WIP] Handle and return errors for metrics registration#31
Closed
fahlmant wants to merge 2 commits intoopenshift:masterfrom
Closed
[WIP] Handle and return errors for metrics registration#31fahlmant wants to merge 2 commits intoopenshift:masterfrom
fahlmant wants to merge 2 commits intoopenshift:masterfrom
Conversation
fahlmant
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Member
|
I have looked at this. It lgtm. Are we on /hold for test coverage? |
Contributor
Author
|
@2uasimojo I'm testing, and the logs aren't done yet. It currently just says "Something" |
fahlmant
force-pushed
the
metric-registration
branch
from
b5c714e to
20fa291
Compare
fahlmant
force-pushed
the
metric-registration
branch
from
ac363de to
41623a9
Compare
Contributor
Author
|
Closing PR until further testing is done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly handles errors during the registration of metrics.